[
https://issues.apache.org/jira/browse/GOBBLIN-1652?focusedWorklogId=773046&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773046
]
ASF GitHub Bot logged work on GOBBLIN-1652:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/May/22 23:14
Start Date: 20/May/22 23:14
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3513:
URL: https://github.com/apache/gobblin/pull/3513#issuecomment-1133455833
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3513?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3513](https://codecov.io/gh/apache/gobblin/pull/3513?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(138d2c8) into
[master](https://codecov.io/gh/apache/gobblin/commit/deb4f4860bf1b6a9db6db5fb608a036fdab40bce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(deb4f48) will **decrease** coverage by `3.23%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3513 +/- ##
============================================
- Coverage 46.71% 43.47% -3.24%
+ Complexity 10420 2040 -8380
============================================
Files 2080 405 -1675
Lines 81266 17466 -63800
Branches 9067 2134 -6933
============================================
- Hits 37966 7594 -30372
+ Misses 39806 9024 -30782
+ Partials 3494 848 -2646
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3513?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/gobblin/pull/3513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `31.70% <0.00%> (-4.27%)` | :arrow_down: |
|
[...blin/service/monitoring/KafkaJobStatusMonitor.java](https://codecov.io/gh/apache/gobblin/pull/3513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9LYWZrYUpvYlN0YXR1c01vbml0b3IuamF2YQ==)
| | |
|
[...g/apache/gobblin/source/extractor/utils/Utils.java](https://codecov.io/gh/apache/gobblin/pull/3513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvdXRpbHMvVXRpbHMuamF2YQ==)
| | |
|
[...apache/gobblin/source/workunit/ExtractFactory.java](https://codecov.io/gh/apache/gobblin/pull/3513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc291cmNlL3dvcmt1bml0L0V4dHJhY3RGYWN0b3J5LmphdmE=)
| | |
|
[...etention/dataset/CleanableDatasetStoreDataset.java](https://codecov.io/gh/apache/gobblin/pull/3513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9kYXRhc2V0L0NsZWFuYWJsZURhdGFzZXRTdG9yZURhdGFzZXQuamF2YQ==)
| | |
|
[...obblin/publisher/TimePartitionedDataPublisher.java](https://codecov.io/gh/apache/gobblin/pull/3513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3B1Ymxpc2hlci9UaW1lUGFydGl0aW9uZWREYXRhUHVibGlzaGVyLmphdmE=)
| | |
|
[...in/data/management/copy/CloseableFsCopySource.java](https://codecov.io/gh/apache/gobblin/pull/3513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvQ2xvc2VhYmxlRnNDb3B5U291cmNlLmphdmE=)
| | |
|
[...pache/gobblin/data/management/trash/MockTrash.java](https://codecov.io/gh/apache/gobblin/pull/3513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3RyYXNoL01vY2tUcmFzaC5qYXZh)
| | |
|
[...ache/gobblin/compaction/dataset/DatasetHelper.java](https://codecov.io/gh/apache/gobblin/pull/3513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vZGF0YXNldC9EYXRhc2V0SGVscGVyLmphdmE=)
| | |
|
[.../src/main/java/org/apache/gobblin/r2/R2Client.java](https://codecov.io/gh/apache/gobblin/pull/3513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4taHR0cC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9yMi9SMkNsaWVudC5qYXZh)
| | |
| ... and [1668
more](https://codecov.io/gh/apache/gobblin/pull/3513/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3513?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3513?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[deb4f48...138d2c8](https://codecov.io/gh/apache/gobblin/pull/3513?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Issue Time Tracking
-------------------
Worklog Id: (was: 773046)
Time Spent: 20m (was: 10m)
> Add more log in the KafkaJobStatusMonitor in case it fails to process one
> GobblinTrackingEvent
> ----------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1652
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1652
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Now in some conner case, we fail to process one kafka message, and it's super
> hard to get the reason for why it fails. To get more info there we want to
> add more log when processing message. Along with this, we need to add null
> check in
> modifyStateIfRetryRequired to avoid NPE as well.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
