[
https://issues.apache.org/jira/browse/GOBBLIN-1654?focusedWorklogId=775590&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-775590
]
ASF GitHub Bot logged work on GOBBLIN-1654:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/May/22 23:01
Start Date: 27/May/22 23:01
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3515:
URL: https://github.com/apache/gobblin/pull/3515#issuecomment-1140092218
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3515?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3515](https://codecov.io/gh/apache/gobblin/pull/3515?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(c18057d) into
[master](https://codecov.io/gh/apache/gobblin/commit/7b29ce2911e5d77410c313f71d315dc8bc82cf5b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(7b29ce2) will **decrease** coverage by `3.23%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3515 +/- ##
============================================
- Coverage 46.71% 43.48% -3.24%
+ Complexity 10426 2041 -8385
============================================
Files 2080 405 -1675
Lines 81305 17476 -63829
Branches 9072 2135 -6937
============================================
- Hits 37985 7600 -30385
+ Misses 39825 9026 -30799
+ Partials 3495 850 -2645
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3515?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/gobblin/pull/3515/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh)
| `40.00% <0.00%> (-20.00%)` | :arrow_down: |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/gobblin/pull/3515/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `85.71% <0.00%> (-7.15%)` | :arrow_down: |
|
[...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/gobblin/pull/3515/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh)
| `60.21% <0.00%> (-2.16%)` | :arrow_down: |
|
[...kunit/packer/KafkaTopicGroupingWorkUnitPacker.java](https://codecov.io/gh/apache/gobblin/pull/3515/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS93b3JrdW5pdC9wYWNrZXIvS2Fma2FUb3BpY0dyb3VwaW5nV29ya1VuaXRQYWNrZXIuamF2YQ==)
| | |
|
[...r/ProduceRateAndLagBasedWorkUnitSizeEstimator.java](https://codecov.io/gh/apache/gobblin/pull/3515/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS93b3JrdW5pdC9wYWNrZXIvUHJvZHVjZVJhdGVBbmRMYWdCYXNlZFdvcmtVbml0U2l6ZUVzdGltYXRvci5qYXZh)
| | |
|
[...che/gobblin/metrics/ContextAwareMetricFactory.java](https://codecov.io/gh/apache/gobblin/pull/3515/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Db250ZXh0QXdhcmVNZXRyaWNGYWN0b3J5LmphdmE=)
| | |
|
[...action/audit/PinotAuditCountHttpClientFactory.java](https://codecov.io/gh/apache/gobblin/pull/3515/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vYXVkaXQvUGlub3RBdWRpdENvdW50SHR0cENsaWVudEZhY3RvcnkuamF2YQ==)
| | |
|
[.../mapreduce/orc/OrcValueCombineFileInputFormat.java](https://codecov.io/gh/apache/gobblin/pull/3515/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL29yYy9PcmNWYWx1ZUNvbWJpbmVGaWxlSW5wdXRGb3JtYXQuamF2YQ==)
| | |
|
[...nt/copy/replication/ConfigBasedDatasetsFinder.java](https://codecov.io/gh/apache/gobblin/pull/3515/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvcmVwbGljYXRpb24vQ29uZmlnQmFzZWREYXRhc2V0c0ZpbmRlci5qYXZh)
| | |
|
[...obblin/runtime/std/DefaultJobSpecScheduleImpl.java](https://codecov.io/gh/apache/gobblin/pull/3515/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvc3RkL0RlZmF1bHRKb2JTcGVjU2NoZWR1bGVJbXBsLmphdmE=)
| | |
| ... and [1670
more](https://codecov.io/gh/apache/gobblin/pull/3515/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3515?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3515?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[7b29ce2...c18057d](https://codecov.io/gh/apache/gobblin/pull/3515?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Issue Time Tracking
-------------------
Worklog Id: (was: 775590)
Time Spent: 20m (was: 10m)
> Add capacity floor to avoid aggressively requesting resource and small files.
> -----------------------------------------------------------------------------
>
> Key: GOBBLIN-1654
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1654
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Now we calculate the capacity based on the consumer rate during peak hour,
> but if there are records with super bad schema during that time, our consumer
> rate will be super low and even after we catch up, we will not be able to
> release the resources because of the low consumer rate. So want provide a
> config to set the minimum consumer rate and avoid abusing resources and small
> files
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
