Will-Lo commented on code in PR #3516: URL: https://github.com/apache/gobblin/pull/3516#discussion_r889340457
########## gobblin-utility/src/main/java/org/apache/gobblin/exception/QuotaExceededException.java: ########## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.gobblin.exception; + +import java.io.IOException; + + +public class QuotaExceededException extends IOException { + + public QuotaExceededException(String message) { + super(message); Review Comment: The message is defined in the `UserQuotaManager`, I think that's an interesting idea but I usually don't see Exception classes in general forcing formatted messages (in case this exception is used outside the scope of GaaS), hence I just pass the message up the stack. I'm open to changing it to be formatted though! Wonder what others think @ZihanLi58 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
