[
https://issues.apache.org/jira/browse/GOBBLIN-1657?focusedWorklogId=778742&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778742
]
ASF GitHub Bot logged work on GOBBLIN-1657:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jun/22 20:20
Start Date: 06/Jun/22 20:20
Worklog Time Spent: 10m
Work Description: vikrambohra opened a new pull request, #3517:
URL: https://github.com/apache/gobblin/pull/3517
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-1657] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1657
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
see description in https://issues.apache.org/jira/browse/GOBBLIN-1657
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 778742)
Remaining Estimate: 0h
Time Spent: 10m
> Update completion watermark on change_property in IcebergMetadataWriter
> ------------------------------------------------------------------------
>
> Key: GOBBLIN-1657
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1657
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Vikram Bohra
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There are quiet topics where data can be generated quiet infrequently causing
> the completion watermark to lag. Also, a commit operation could miss
> completion watermark update if there is a lag in kafka audit.
> To fix above issues:
> # Added logic to check audit count on change_property operation type for the
> next window of current watermark
> # If counts match or an empty map is returned then consider audit count as
> complete and update the watermark.
> Added a config in KafkaAuditVerifier to return complete if found an empty map
> (with no counts from audit system)
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
