umustafi opened a new pull request, #3518: URL: https://github.com/apache/gobblin/pull/3518
Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [X] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-1658 ### Description - [X] Here are some details about my PR, including screenshots (if applicable): Remove extra parameter from user side differentiating snapshot and partitioned copy. User shouldn't have to provide this flag. We can generalize the default values of partition format, column, and conflict policy without knowing this. ### Tests - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: I updated the unit test for HiveDatasetDescriptor and am testing both snapshot and partition hive copies with local deployment of GaaS to see if the default values set work. [Will update here with details] ### Commits - [X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
