[
https://issues.apache.org/jira/browse/GOBBLIN-1658?focusedWorklogId=778809&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778809
]
ASF GitHub Bot logged work on GOBBLIN-1658:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/22 01:25
Start Date: 07/Jun/22 01:25
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3518:
URL: https://github.com/apache/gobblin/pull/3518#issuecomment-1148094664
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3518?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3518](https://codecov.io/gh/apache/gobblin/pull/3518?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(0a2b501) into
[master](https://codecov.io/gh/apache/gobblin/commit/e814aafad32f81948e6d49f39a50e5a2ae117884?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(e814aaf) will **decrease** coverage by `3.22%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3518 +/- ##
============================================
- Coverage 46.72% 43.49% -3.23%
+ Complexity 10426 2043 -8383
============================================
Files 2080 405 -1675
Lines 81318 17476 -63842
Branches 9075 2135 -6940
============================================
- Hits 37994 7602 -30392
+ Misses 39829 9027 -30802
+ Partials 3495 847 -2648
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3518?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...service/modules/dataset/HiveDatasetDescriptor.java](https://codecov.io/gh/apache/gobblin/pull/3518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9kYXRhc2V0L0hpdmVEYXRhc2V0RGVzY3JpcHRvci5qYXZh)
| | |
|
[...rg/apache/gobblin/converter/IdentityConverter.java](https://codecov.io/gh/apache/gobblin/pull/3518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29udmVydGVyL0lkZW50aXR5Q29udmVydGVyLmphdmE=)
| | |
|
[...te\_catalog/ObservingFSFlowEdgeTemplateCatalog.java](https://codecov.io/gh/apache/gobblin/pull/3518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy90ZW1wbGF0ZV9jYXRhbG9nL09ic2VydmluZ0ZTRmxvd0VkZ2VUZW1wbGF0ZUNhdGFsb2cuamF2YQ==)
| | |
|
[.../java/org/apache/gobblin/metrics/Measurements.java](https://codecov.io/gh/apache/gobblin/pull/3518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9NZWFzdXJlbWVudHMuamF2YQ==)
| | |
|
[...va/org/apache/gobblin/source/workunit/Extract.java](https://codecov.io/gh/apache/gobblin/pull/3518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc291cmNlL3dvcmt1bml0L0V4dHJhY3QuamF2YQ==)
| | |
|
[...gobblin/compaction/CompactorCreationException.java](https://codecov.io/gh/apache/gobblin/pull/3518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vQ29tcGFjdG9yQ3JlYXRpb25FeGNlcHRpb24uamF2YQ==)
| | |
|
[...che/gobblin/runtime/api/GobblinInstanceDriver.java](https://codecov.io/gh/apache/gobblin/pull/3518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0dvYmJsaW5JbnN0YW5jZURyaXZlci5qYXZh)
| | |
|
[...ment/conversion/hive/validation/ValidationJob.java](https://codecov.io/gh/apache/gobblin/pull/3518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXprYWJhbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9kYXRhL21hbmFnZW1lbnQvY29udmVyc2lvbi9oaXZlL3ZhbGlkYXRpb24vVmFsaWRhdGlvbkpvYi5qYXZh)
| | |
|
[...apache/gobblin/writer/GobblinOrcWriterBuilder.java](https://codecov.io/gh/apache/gobblin/pull/3518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tb3JjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9Hb2JibGluT3JjV3JpdGVyQnVpbGRlci5qYXZh)
| | |
|
[...a/management/copy/hive/HiveLocationDescriptor.java](https://codecov.io/gh/apache/gobblin/pull/3518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaGl2ZS9IaXZlTG9jYXRpb25EZXNjcmlwdG9yLmphdmE=)
| | |
| ... and [1667
more](https://codecov.io/gh/apache/gobblin/pull/3518/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3518?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3518?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[e814aaf...0a2b501](https://codecov.io/gh/apache/gobblin/pull/3518?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Issue Time Tracking
-------------------
Worklog Id: (was: 778809)
Time Spent: 20m (was: 10m)
> Remove isPartitioned reference from HiveDatasetDescriptor
> ---------------------------------------------------------
>
> Key: GOBBLIN-1658
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1658
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Remove extra parameter from user side differentiating snapshot and
> partitioned copy. User shouldn't have to provide this flag. We can generalize
> the default values of partition format, column, and conflict policy without
> knowing this.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
