ZihanLi58 commented on code in PR #3521:
URL: https://github.com/apache/gobblin/pull/3521#discussion_r896083615
##########
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/writer/HiveMetadataWriter.java:
##########
@@ -138,7 +138,9 @@ public void flush(String dbName, String tableName) throws
IOException {
//iterator all execution to get the result to make sure they all
succeeded
for (HashMap.Entry<List<String>, ListenableFuture<Void>> execution :
executionMap.entrySet()) {
try {
+ log.debug("Start registering partition during hive write for db: " +
dbName + " table: " + tableName + " partition: " +
Joiner.on(",").join(execution.getKey()));
execution.getValue().get(timeOutSeconds, TimeUnit.SECONDS);
Review Comment:
As this is ascync call, even we don't call get here, the hive registration
might be executed as well, and in that case, we may miss the event
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
