[
https://issues.apache.org/jira/browse/GOBBLIN-1663?focusedWorklogId=780919&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-780919
]
ASF GitHub Bot logged work on GOBBLIN-1663:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jun/22 19:56
Start Date: 13/Jun/22 19:56
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on code in PR #3521:
URL: https://github.com/apache/gobblin/pull/3521#discussion_r896083615
##########
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/writer/HiveMetadataWriter.java:
##########
@@ -138,7 +138,9 @@ public void flush(String dbName, String tableName) throws
IOException {
//iterator all execution to get the result to make sure they all
succeeded
for (HashMap.Entry<List<String>, ListenableFuture<Void>> execution :
executionMap.entrySet()) {
try {
+ log.debug("Start registering partition during hive write for db: " +
dbName + " table: " + tableName + " partition: " +
Joiner.on(",").join(execution.getKey()));
execution.getValue().get(timeOutSeconds, TimeUnit.SECONDS);
Review Comment:
As this is ascync call, even we don't call get here, the hive registration
might be executed as well, and in that case, we may miss the event
Issue Time Tracking
-------------------
Worklog Id: (was: 780919)
Time Spent: 20m (was: 10m)
> Add some debug log lines around GMIP hive commit events
> -------------------------------------------------------
>
> Key: GOBBLIN-1663
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1663
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
