cbrentharris opened a new pull request, #3526:
URL: https://github.com/apache/gobblin/pull/3526

   Currently the hive.dataset.existing.entity.policy.ABORT will not
   abort if there is an existing partition. One option to resolve this
   is to support the ABORT configuration but that might be backwards
   incompatible, so introducing a new skip predicate called
   ExistingPartitionSkipPredicate that will skip any partition that
   already exists in the target table
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1667
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if 
applicable):
   
   My PR introduces a new simple skip predicate called 
ExistingPartitionSkipPredicate which will skip the partition if it exists in 
the target table.
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   My PR adds a unit test for the new predicate
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to