Will-Lo commented on code in PR #3536: URL: https://github.com/apache/gobblin/pull/3536#discussion_r948488182
########## gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/GitConfigMonitor.java: ########## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.gobblin.service.monitoring; + +import com.google.common.collect.ImmutableMap; +import com.typesafe.config.Config; +import com.typesafe.config.ConfigFactory; + +import javax.inject.Inject; +import javax.inject.Singleton; +import lombok.extern.slf4j.Slf4j; + +import org.apache.gobblin.configuration.ConfigurationKeys; +import org.apache.gobblin.runtime.spec_catalog.FlowCatalog; + +/** + * Service that monitors for jobs from a git repository. Review Comment: So it seems this is such an old module that it was conceived before FlowConfigs were properly utilized with the API, based on the tests I see it actually stores Gobblin jobs into the specStore, but technically nothing is stopping it from loading flowConfigs and storing them into the MysqlSpecStore if the serDe of the changed file is compatible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
