[
https://issues.apache.org/jira/browse/GOBBLIN-1678?focusedWorklogId=802623&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-802623
]
ASF GitHub Bot logged work on GOBBLIN-1678:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Aug/22 20:22
Start Date: 22/Aug/22 20:22
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3536:
URL: https://github.com/apache/gobblin/pull/3536#discussion_r951877591
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flowgraph/BaseFlowGraphListener.java:
##########
@@ -15,172 +15,85 @@
* limitations under the License.
*/
-package org.apache.gobblin.service.modules.core;
-
-import java.io.IOException;
-import java.net.URI;
-import java.net.URISyntaxException;
-import java.util.ArrayList;
-import java.util.Collections;
-import java.util.List;
-import java.util.Map;
-import java.util.concurrent.CountDownLatch;
-
-import org.apache.hadoop.fs.Path;
-import org.eclipse.jgit.api.errors.GitAPIException;
-import org.eclipse.jgit.diff.DiffEntry;
+package org.apache.gobblin.service.modules.flowgraph;
import com.google.common.base.Joiner;
import com.google.common.base.Optional;
-import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.Sets;
import com.google.common.io.Files;
import com.typesafe.config.Config;
import com.typesafe.config.ConfigFactory;
import com.typesafe.config.ConfigValueFactory;
-
+import java.io.IOException;
Review Comment:
The import order is against the codestyle
https://gobblin.readthedocs.io/en/latest/developer-guide/CodingStyle/
Issue Time Tracking
-------------------
Worklog Id: (was: 802623)
Time Spent: 2h 40m (was: 2.5h)
> Refactor GaaS Flowgraph Monitor to be extensible
> ------------------------------------------------
>
> Key: GOBBLIN-1678
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1678
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: William Lo
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> To support new implementations of a flow graph monitor, which allows for live
> updating of a flowgraph, we should reuse as much implementation from the
> existing git flowgraph monitor as possible.
> The current flowgraph monitor has coupled logic to perform a lot of the
> adding node/edges which can be reused for a file based flowgraph.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
