[
https://issues.apache.org/jira/browse/GOBBLIN-1684?focusedWorklogId=803383&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-803383
]
ASF GitHub Bot logged work on GOBBLIN-1684:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Aug/22 21:00
Start Date: 24/Aug/22 21:00
Worklog Time Spent: 10m
Work Description: homatthew commented on code in PR #3540:
URL: https://github.com/apache/gobblin/pull/3540#discussion_r954295517
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/messaging/hdfs/FileSystemMessageBuffer.java:
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gobblin.runtime.messaging.hdfs;
+
+import com.google.gson.JsonElement;
+import java.io.IOException;
+import java.util.Collection;
+import lombok.AllArgsConstructor;
+import lombok.Getter;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+
+
+/**
+ * Implements {@link FileSystem} based message buffer for sending {@link
JsonElement} based messages. This buffer does
+ * not guarantee FIFO and does not have any safeguards for concurrent readers
/ writers.
+ */
+@AllArgsConstructor
+public class FileSystemMessageBuffer {
+ private final FileSystem fs;
+ private final Path dir;
+
+ /**
+ * Write a {@link JsonElement} to the buffer
+ * @param message message to be written
+ * @return if the message was successfully persisted to {@link FileSystem}
+ */
+ public boolean add(JsonElement message) {
+ // STUB: TODO GOBBLIN-1685
+ return true;
+ }
+
+ /**
+ * Get all messages from the buffer that have not been {@link
AcknowledgeableMessage#ack()}
+ * @return list of messages that still need to be processed
+ */
+ public Collection<AcknowledgeableMessage> getUnacknowledgedMessages() {
+ // STUB: TODO GOBBLIN-1685
+ return null;
+ }
+
+ private boolean delete(Path filePath) throws IOException {
+ // STUB: TODO GOBBLIN-1685
+ return true;
+ }
+
+ /**
+ * Wrapper for {@link JsonElement} messages on disk that provides api's for
an acknowledgement after processing
+ * (i.e. cleaning up the file on disk after done processing)
+ */
+ @AllArgsConstructor
+ public static class AcknowledgeableMessage {
Review Comment:
Discussed offline with @hanghangliu that this is not really needed because
the underlying files can be deleted right away after reading.
Issue Time Tracking
-------------------
Worklog Id: (was: 803383)
Time Spent: 0.5h (was: 20m)
> Interface / Stub for HDFS Writer for Dynamic Work Unit Allocation
> Communication
> -------------------------------------------------------------------------------
>
> Key: GOBBLIN-1684
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1684
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> As part of the initial implementation for Helix Dynamic Workunit Allocation,
> the application master and task runners will communicate via HDFS by writing
> to a path and then the task runner needs to poll that path for new files
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
