[
https://issues.apache.org/jira/browse/GOBBLIN-1690?focusedWorklogId=803438&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-803438
]
ASF GitHub Bot logged work on GOBBLIN-1690:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Aug/22 03:49
Start Date: 25/Aug/22 03:49
Worklog Time Spent: 10m
Work Description: rdsr commented on code in PR #3543:
URL: https://github.com/apache/gobblin/pull/3543#discussion_r954474766
##########
gobblin-modules/gobblin-orc/src/main/java/org/apache/gobblin/writer/GenericRecordToOrcValueWriter.java:
##########
@@ -344,7 +346,9 @@ public void addValue(int rowId, int column, Object data,
ColumnVector output) {
// make sure the child is big enough
if (cv.childCount > cv.keys.isNull.length) {
int resizedLength = resize(rowsAdded, cv.isNull.length, cv.childCount);
+ log.info("Column vector: {}, resizing to: {}, child count: {}",
cv.keys, resizedLength, cv.childCount);
cv.keys.ensureSize(resizedLength, true);
+ log.info("Column vector: {}, resizing to: {}, child count: {}",
cv.values, resizedLength, cv.childCount);
Review Comment:
I'm looking to log something like this
```Column vector:
org.apache.orc.storage.ql.exec.vector.BytesColumnVector@6a4c0a7f, resizing to:
257610, child count: 25761``` where I need both the identityHash and the
referring class name.
I can look into the Util class. Can u point me to it? But IMO might be an
overkill in replacing `cv` to `GobblinUtil.hash(cv)` , no?
Issue Time Tracking
-------------------
Worklog Id: (was: 803438)
Time Spent: 1h (was: 50m)
> [Minor] Improve ORC logging in Gobblin ORC Writer
> -------------------------------------------------
>
> Key: GOBBLIN-1690
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1690
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Ratandeep Ratti
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
