Will-Lo commented on code in PR #3545: URL: https://github.com/apache/gobblin/pull/3545#discussion_r958750903
########## gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/MysqlUserQuotaManager.java: ########## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.service.modules.orchestration; + +import java.io.IOException; +import java.sql.Connection; +import java.sql.PreparedStatement; +import java.sql.ResultSet; +import java.sql.SQLException; +import java.util.Collection; + +import org.apache.commons.dbcp.BasicDataSource; + +import com.google.common.annotations.VisibleForTesting; +import com.google.inject.Inject; +import com.typesafe.config.Config; + +import javax.inject.Singleton; +import javax.sql.DataSource; +import lombok.extern.slf4j.Slf4j; + +import org.apache.gobblin.configuration.ConfigurationKeys; +import org.apache.gobblin.metastore.MysqlStateStore; +import org.apache.gobblin.service.modules.flowgraph.Dag; +import org.apache.gobblin.service.modules.spec.JobExecutionPlan; +import org.apache.gobblin.util.ConfigUtils; + + +/** + * An implementation of {@link UserQuotaManager} that stores quota usage in mysql. + */ +@Slf4j +@Singleton +public class MysqlUserQuotaManager extends AbstractUserQuotaManager { + private final MysqlQuotaStore mysqlStore; + + @Inject + public MysqlUserQuotaManager(Config config) throws IOException { + super(config); + this.mysqlStore = createQuotaStore(config); + } + + // This implementation does not need to update quota usage when the service restarts or it's leadership status changes + public void init(Collection<Dag<JobExecutionPlan>> dags) { Review Comment: I'm confused why we don't need to update quota usage when the service restarts. What happens when the scheduler goes down? Unless we always assume that another host will perfectly transfer its workload to another host, there can always be some scenario where the dagstatestore doesn't reflect the quotas right? ########## gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/AbstractUserQuotaManager.java: ########## @@ -0,0 +1,239 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.service.modules.orchestration; + +import java.io.IOException; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.concurrent.ConcurrentHashMap; + +import com.google.common.collect.ImmutableMap; +import com.typesafe.config.Config; + +import lombok.AllArgsConstructor; +import lombok.Setter; +import lombok.extern.slf4j.Slf4j; + +import org.apache.gobblin.configuration.ConfigurationKeys; +import org.apache.gobblin.exception.QuotaExceededException; +import org.apache.gobblin.service.RequesterService; +import org.apache.gobblin.service.ServiceRequester; +import org.apache.gobblin.service.modules.flowgraph.Dag; +import org.apache.gobblin.service.modules.spec.JobExecutionPlan; +import org.apache.gobblin.util.ConfigUtils; + + +/** + * An abstract implementation of {@link UserQuotaManager} that + */ +@Slf4j +abstract public class AbstractUserQuotaManager implements UserQuotaManager { + public static final String PER_USER_QUOTA = DagManager.DAG_MANAGER_PREFIX + "perUserQuota"; + public static final String PER_FLOWGROUP_QUOTA = DagManager.DAG_MANAGER_PREFIX + "perFlowGroupQuota"; + public static final String USER_JOB_QUOTA_KEY = DagManager.DAG_MANAGER_PREFIX + "defaultJobQuota"; + public static final String QUOTA_SEPERATOR = ":"; + public static final Integer DEFAULT_USER_JOB_QUOTA = Integer.MAX_VALUE; + private final Map<String, Integer> perUserQuota; + private final Map<String, Integer> perFlowGroupQuota; + Set<String> runningDagIds = ConcurrentHashMap.newKeySet(); Review Comment: For context, we use runningDagIds to guard against multi increments and decrements that can happen in startup/shutdown situations. It also guards against scenarios where adhoc/runImmediately flows need to validate the quota in the scheduler and not the DagManager -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
