[GitHub] [gobblin] Will-Lo commented on a diff in pull request #3551: [GOBBLIN-1695] Fix: Failure to add spec executors doesn't block deployment

[GitBox]

Will-Lo commented on code in PR #3551:
URL: https://github.com/apache/gobblin/pull/3551#discussion_r966181310


##########
gobblin-modules/gobblin-azkaban/src/main/java/org/apache/gobblin/service/modules/orchestration/AzkabanClient.java:
##########
@@ -130,10 +138,12 @@ private void initializeClient() throws 
AzkabanClientException {
 
   private void initializeSessionManager() throws AzkabanClientException {
     if (sessionManager == null) {
-      this.sessionManager = new AzkabanSessionManager(this.httpClient,
-                                                      this.url,
-                                                      this.username,
-                                                      this.password);
+      try {
+        this.sessionManager = new AzkabanSessionManager(this.httpClient, 
this.url, this.username, this.password);
+      }
+      catch(Exception e) {
+        log.error("Failed to initialize session manager due to: ", e);

Review Comment:
   I don't see the SessionManager actually throwing anything in the constructor 
so the try/catch is redundant



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org