ZihanLi58 commented on code in PR #3552:
URL: https://github.com/apache/gobblin/pull/3552#discussion_r966284981


##########
gobblin-compaction/src/main/java/org/apache/gobblin/compaction/mapreduce/orc/OrcKeyDedupReducer.java:
##########
@@ -61,6 +62,11 @@ protected void reduce(OrcKey key, Iterable<OrcValue> values, 
Context context)
     int valueHash = 0;
 
     for (OrcValue value : values) {
+      recordCounter++;
+      if (recordCounter % 1000 == 0) {
+        log.info("Reduced %s values for key %s", recordCounter, key);

Review Comment:
   Seems like the log does not looks correct after you move it to class level. 
   You also want to print one log when we start to reduce the first record?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to