ZihanLi58 commented on code in PR #3556:
URL: https://github.com/apache/gobblin/pull/3556#discussion_r966508754
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/HelixUtils.java:
##########
@@ -278,13 +278,16 @@ static void waitJobCompletion(HelixManager helixManager,
String workFlowName, St
case STOPPING:
log.info("Waiting for job {} to complete... State - {}", jobName,
jobState);
Thread.sleep(TimeUnit.SECONDS.toMillis(1L));
+ if (stoppingStateEndTime == null) {
+ stoppingStateEndTime = jobStartTimeMillis +
stoppingStateTimeoutInSeconds * 1000;
Review Comment:
why start from jobStartTimeMills? Shouldn't it be currentTimeStamp?
Basically it should be the first time we see job in stopping state plus the
stopping state timeout.
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/HelixUtils.java:
##########
@@ -278,13 +278,16 @@ static void waitJobCompletion(HelixManager helixManager,
String workFlowName, St
case STOPPING:
log.info("Waiting for job {} to complete... State - {}", jobName,
jobState);
Thread.sleep(TimeUnit.SECONDS.toMillis(1L));
+ if (stoppingStateEndTime == null) {
+ stoppingStateEndTime = jobStartTimeMillis +
stoppingStateTimeoutInSeconds * 1000;
Review Comment:
Also add one log here indicate we see job in stopping state so that you will
be able to test whether your fix works?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
