Will-Lo commented on code in PR #3559: URL: https://github.com/apache/gobblin/pull/3559#discussion_r968956201
########## gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergSnapshotInfo.java: ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.data.management.copy.iceberg; + +import com.google.common.collect.Lists; +import java.time.Instant; + +import java.util.List; + +import java.util.stream.Collectors; +import lombok.AllArgsConstructor; +import lombok.Getter; +import lombok.extern.slf4j.Slf4j; + Review Comment: Small nit but in Gobblin there's an import order based on the style guide, I learned about this recently so I'm looking as to ways to easily enforce this but here's the link to the guide: https://gobblin.readthedocs.io/en/latest/developer-guide/CodingStyle/ You can install it on your intellij to and set it to autoformat your files. ########## gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergSnapshotInfo.java: ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.data.management.copy.iceberg; + +import com.google.common.collect.Lists; +import java.time.Instant; + +import java.util.List; + +import java.util.stream.Collectors; +import lombok.AllArgsConstructor; +import lombok.Getter; +import lombok.extern.slf4j.Slf4j; + + +/** + * Information about the metadata file and data file paths of a single Iceberg Snapshot. + */ +@Slf4j +@AllArgsConstructor +@Getter +public class IcebergSnapshotInfo { + + private final Long snapshotId; + private final Instant timestamp; + private final String metadataPath; + private final String manifestListPath; + private final List<String> manifestFilePaths; + private final List<List<String>> manifestListedFilePaths; // NOTE: order parallels that of `manifestFilePaths` Review Comment: If these objects are logically linked and order enforced, would it make sense to make it a list of a new class, say IcebergManifestFiles objects? And each object would contain a manifest file path and a manifest list. and this object can have an interface to fetch all the files for `getAllPaths()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
