[
https://issues.apache.org/jira/browse/GOBBLIN-1706?focusedWorklogId=808500&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-808500
]
ASF GitHub Bot logged work on GOBBLIN-1706:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Sep/22 02:44
Start Date: 14/Sep/22 02:44
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3558:
URL: https://github.com/apache/gobblin/pull/3558#discussion_r970255068
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/dag_action_store/MysqlDagActionStore.java:
##########
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.runtime.dag_action_store;
+
+import com.google.inject.Inject;
+import com.typesafe.config.Config;
+import java.io.IOException;
+import java.sql.Connection;
+import java.sql.PreparedStatement;
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.util.Collection;
+import java.util.HashSet;
+import javax.sql.DataSource;
+import org.apache.gobblin.configuration.ConfigurationKeys;
+import org.apache.gobblin.metastore.MysqlStateStore;
+import org.apache.gobblin.runtime.api.DagActionStore;
+import org.apache.gobblin.service.ServiceConfigKeys;
+import org.apache.gobblin.util.ConfigUtils;
+
+
+public class MysqlDagActionStore implements DagActionStore {
+
+ public static final String CONFIG_PREFIX = "MysqlDagActionStore";
+
+
+ protected final DataSource dataSource;
+ private final String tableName;
+ private static final String EXISTS_STATEMENT = "SELECT EXISTS(SELECT * FROM
%s WHERE flow_group = ? AND flow_name =? AND flow_execution_id = ?)";
+
+ protected static final String INSERT_STATEMENT = "INSERT INTO %s
(flow_group, flow_name, flow_execution_id, dag_action ) "
+ + "VALUES (?, ?, ?, ?)";
+ private static final String DELETE_STATEMENT = "DELETE FROM %s WHERE
flow_group = ? AND flow_name =? AND flow_execution_id = ?";
+ private static final String GET_STATEMENT = "SELECT flow_group, flow_name,
flow_execution_id, dag_action FROM %s WHERE flow_group = ? AND flow_name =? AND
flow_execution_id = ?";
+ private static final String GET_ALL_STATEMENT = "SELECT flow_group,
flow_name, flow_execution_id, dag_action FROM %s";
+ private static final String CREATE_TABLE_STATEMENT = "CREATE TABLE IF NOT
EXISTS %s (" +
+ "flow_group varchar(" + ServiceConfigKeys.MAX_FLOW_GROUP_LENGTH + ") NOT
NULL, flow_name varchar(" + ServiceConfigKeys.MAX_FLOW_GROUP_LENGTH + ") NOT
NULL, flow_execution_id varchar(100) NOT NULL," +
+ "dag_action varchar(100) NOT NULL, modified_time TIMESTAMP DEFAULT
CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP NOT NULL, "
+ + "PRIMARY KEY (flow_group,flow_name,flow_execution_id))";
+
+ @Inject
+ public MysqlDagActionStore(Config config) throws IOException {
+ if (config.hasPath(CONFIG_PREFIX)) {
+ config = config.getConfig(CONFIG_PREFIX).withFallback(config);
+ } else {
+ throw new IOException("Please specify the config for
MysqlDagActionStore");
+ }
+ this.tableName = ConfigUtils.getString(config,
ConfigurationKeys.STATE_STORE_DB_TABLE_KEY,
+ ConfigurationKeys.DEFAULT_STATE_STORE_DB_TABLE);
+
+ this.dataSource = MysqlStateStore.newDataSource(config);
+ try (Connection connection = dataSource.getConnection();
+ PreparedStatement createStatement =
connection.prepareStatement(String.format(CREATE_TABLE_STATEMENT, tableName))) {
+ createStatement.executeUpdate();
+ connection.commit();
+ } catch (SQLException e) {
+ throw new IOException("Failure creation table " + tableName, e);
+ }
+ }
+
+ @Override
+ public boolean exists(String flowGroup, String flowName, String
flowExecutionId) throws IOException, SQLException {
+ ResultSet rs = null;
+ try (Connection connection = this.dataSource.getConnection();
+ PreparedStatement existStatement =
connection.prepareStatement(String.format(EXISTS_STATEMENT, tableName))) {
+ int i = 0;
+ existStatement.setString(++i, flowGroup);
+ existStatement.setString(++i, flowName);
+ existStatement.setString(++i, flowExecutionId);
+ rs = existStatement.executeQuery();
+ rs.next();
+ return rs.getBoolean(1);
+ } catch (SQLException e) {
+ throw new IOException(String.format("Failure checking existence for
table %s of flow with flow group:%s, flow name:%s and flow execution id:%s",
+ tableName, flowGroup, flowName, flowExecutionId), e);
+ } finally {
+ if (rs != null) {
+ rs.close();
+ }
+ }
+ }
+
+ @Override
+ public void addDagAction(String flowGroup, String flowName, String
flowExecutionId, DagActionValue dagActionValue)
+ throws IOException {
+ try (Connection connection = this.dataSource.getConnection();
+ PreparedStatement insertStatement =
connection.prepareStatement(String.format(INSERT_STATEMENT, tableName))) {
+ int i = 0;
+ insertStatement.setString(++i, flowGroup);
+ insertStatement.setString(++i, flowName);
+ insertStatement.setString(++i, flowExecutionId);
+ insertStatement.setString(++i, dagActionValue.toString());
+ insertStatement.executeUpdate();
+ connection.commit();
+ } catch (SQLException e) {
+ throw new IOException(String.format("Failure to adding action for table
%s of flow with flow group:%s, flow name:%s and flow execution id:%s",
+ tableName, flowGroup, flowName, flowExecutionId), e);
+ }
+ }
+
+ @Override
+ public boolean deleteDagAction(String flowGroup, String flowName, String
flowExecutionId) throws IOException {
+ try (Connection connection = this.dataSource.getConnection();
+ PreparedStatement deleteStatement =
connection.prepareStatement(String.format(DELETE_STATEMENT, tableName))) {
+ int i = 0;
+ deleteStatement.setString(++i, flowGroup);
+ deleteStatement.setString(++i, flowName);
+ deleteStatement.setString(++i, flowExecutionId);
+ int result = deleteStatement.executeUpdate();
+ connection.commit();
Review Comment:
same thing, L125 can be removed and return value can be returned inline
Issue Time Tracking
-------------------
Worklog Id: (was: 808500)
Time Spent: 2h (was: 1h 50m)
> Add DagActionStore to store the action to kill/resume one flow execution
> ------------------------------------------------------------------------
>
> Key: GOBBLIN-1706
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1706
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
