[
https://issues.apache.org/jira/browse/GOBBLIN-1710?focusedWorklogId=808932&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-808932
]
ASF GitHub Bot logged work on GOBBLIN-1710:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Sep/22 01:11
Start Date: 15/Sep/22 01:11
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3562:
URL: https://github.com/apache/gobblin/pull/3562#issuecomment-1247455946
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3562?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3562](https://codecov.io/gh/apache/gobblin/pull/3562?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(1640dd9) into
[master](https://codecov.io/gh/apache/gobblin/commit/da914e272c935c519af9d60c1b35a1ab59f1165e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(da914e2) will **increase** coverage by `0.95%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3562 +/- ##
============================================
+ Coverage 46.76% 47.71% +0.95%
+ Complexity 10510 3342 -7168
============================================
Files 2099 665 -1434
Lines 81988 26493 -55495
Branches 9132 3114 -6018
============================================
- Hits 38340 12642 -25698
+ Misses 40104 12518 -27586
+ Partials 3544 1333 -2211
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3562?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...e/gobblin/service/monitoring/GitConfigMonitor.java](https://codecov.io/gh/apache/gobblin/pull/3562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9HaXRDb25maWdNb25pdG9yLmphdmE=)
| `95.23% <0.00%> (-4.77%)` | :arrow_down: |
|
[...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/gobblin/pull/3562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=)
| `70.00% <0.00%> (-2.23%)` | :arrow_down: |
|
[...in/source/extractor/watermark/SimpleWatermark.java](https://codecov.io/gh/apache/gobblin/pull/3562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3Ivd2F0ZXJtYXJrL1NpbXBsZVdhdGVybWFyay5qYXZh)
| | |
|
[...ement/copy/replication/SourceHadoopFsEndPoint.java](https://codecov.io/gh/apache/gobblin/pull/3562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvcmVwbGljYXRpb24vU291cmNlSGFkb29wRnNFbmRQb2ludC5qYXZh)
| | |
|
[...che/gobblin/runtime/local/CliLocalJobLauncher.java](https://codecov.io/gh/apache/gobblin/pull/3562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9jYWwvQ2xpTG9jYWxKb2JMYXVuY2hlci5qYXZh)
| | |
|
[...gobblin/compaction/mapreduce/MRCompactionTask.java](https://codecov.io/gh/apache/gobblin/pull/3562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL01SQ29tcGFjdGlvblRhc2suamF2YQ==)
| | |
|
[...he/gobblin/metrics/event/JobStateEventBuilder.java](https://codecov.io/gh/apache/gobblin/pull/3562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9ldmVudC9Kb2JTdGF0ZUV2ZW50QnVpbGRlci5qYXZh)
| | |
|
[...ement/retention/policy/CombineRetentionPolicy.java](https://codecov.io/gh/apache/gobblin/pull/3562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9wb2xpY3kvQ29tYmluZVJldGVudGlvblBvbGljeS5qYXZh)
| | |
|
[...anagement/dataset/DefaultFileSystemGlobFinder.java](https://codecov.io/gh/apache/gobblin/pull/3562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2RhdGFzZXQvRGVmYXVsdEZpbGVTeXN0ZW1HbG9iRmluZGVyLmphdmE=)
| | |
|
[...management/partition/CopyableDatasetRequestor.java](https://codecov.io/gh/apache/gobblin/pull/3562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3BhcnRpdGlvbi9Db3B5YWJsZURhdGFzZXRSZXF1ZXN0b3IuamF2YQ==)
| | |
| ... and [1429
more](https://codecov.io/gh/apache/gobblin/pull/3562/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Issue Time Tracking
-------------------
Worklog Id: (was: 808932)
Time Spent: 0.5h (was: 20m)
> Codecov should be optional in CI and not fail Github Actions
> ------------------------------------------------------------
>
> Key: GOBBLIN-1710
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1710
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Codecov is flakey and is only useful for determining code coverage. Failure
> to upload should not fail github actions
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
