meethngala commented on code in PR #3560: URL: https://github.com/apache/gobblin/pull/3560#discussion_r972158731
########## gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergDatasetFinder.java: ########## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.data.management.copy.iceberg; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.Iterator; +import java.util.List; +import java.util.Properties; +import lombok.AllArgsConstructor; +import lombok.extern.slf4j.Slf4j; +import org.apache.gobblin.dataset.DatasetConstants; +import org.apache.gobblin.dataset.IterableDatasetFinder; +import org.apache.gobblin.util.HadoopUtils; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; + +/** + * Finds {@link IcebergDataset}s. Will look for tables in a database using a {@link IcebergCatalog}, + * and creates a {@link IcebergDataset} for each one. + */ +@Slf4j +@AllArgsConstructor +public class IcebergDatasetFinder implements IterableDatasetFinder<IcebergDataset> { + + public static final String ICEBERG_DATASET_PREFIX = "iceberg.dataset"; + public static final String ICEBERG_METASTORE_URI_KEY = ICEBERG_DATASET_PREFIX + ".hive.metastore.uri"; + public static final String ICEBERG_DB_NAME = DatasetConstants.PLATFORM_ICEBERG + ".database.name"; + public static final String ICEBERG_TABLE_NAME = DatasetConstants.PLATFORM_ICEBERG + ".table.name"; + + private String dbName; + private String tblName; + private final Properties properties; + protected final FileSystem fs; + + @Override + public List<IcebergDataset> findDatasets() throws IOException { + List<IcebergDataset> matchingDatasets = new ArrayList<>(); + /* + * Both Iceberg database name and table name are mandatory, + * since we are currently only supporting Hive Catalog based Iceberg tables. Review Comment: makes sense. Updated the doc accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
