meethngala commented on code in PR #3560: URL: https://github.com/apache/gobblin/pull/3560#discussion_r972188247
########## gobblin-data-management/src/test/java/org/apache/gobblin/data/management/copy/iceberg/IcebergDatasetTest.java: ########## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.data.management.copy.iceberg; + +import com.google.api.client.util.Maps; +import com.google.gson.Gson; +import com.google.gson.JsonObject; +import java.io.IOException; +import java.net.URI; +import java.net.URISyntaxException; +import java.time.Instant; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collection; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Properties; +import java.util.Set; +import org.apache.gobblin.data.management.copy.CopyConfiguration; +import org.apache.gobblin.data.management.copy.CopyContext; +import org.apache.gobblin.data.management.copy.CopyEntity; +import org.apache.gobblin.data.management.copy.PreserveAttributes; +import org.apache.hadoop.fs.FileStatus; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; +import org.apache.iceberg.TableOperations; +import org.mockito.Mockito; +import org.testng.Assert; +import org.testng.annotations.Test; + +import static org.mockito.Matchers.*; + + +public class IcebergDatasetTest { + + static final String METADATA_PATH = "/root/iceberg/test/metadata"; + static final String MANIFEST_PATH = "/root/iceberg/test/metadata/test_manifest"; + static final String MANIFEST_FILE_PATH1 = "/root/iceberg/test/metadata/test_manifest/data/a"; + static final String MANIFEST_FILE_PATH2 = "/root/iceberg/test/metadata/test_manifest/data/b"; + + @Test + public void testGetFilePaths() throws IOException { + + List<String> pathsToCopy = new ArrayList<>(); + pathsToCopy.add(MANIFEST_FILE_PATH1); + pathsToCopy.add(MANIFEST_FILE_PATH2); + Map<Path, FileStatus> expected = Maps.newHashMap(); + expected.put(new Path(MANIFEST_FILE_PATH1), null); + expected.put(new Path(MANIFEST_FILE_PATH2), null); + + IcebergTable icebergTable = Mockito.mock(IcebergTable.class); + FileSystem fs = Mockito.mock(FileSystem.class); + IcebergSnapshotInfo icebergSnapshotInfo = Mockito.mock(IcebergSnapshotInfo.class); + + Mockito.when(icebergTable.getCurrentSnapshotInfo()).thenReturn(icebergSnapshotInfo); + Mockito.when(icebergSnapshotInfo.getAllPaths()).thenReturn(pathsToCopy); + IcebergDataset icebergDataset = new IcebergDataset("test_db_name", "test_tbl_name", icebergTable, new Properties(), fs); + + Map<Path, FileStatus> actual = icebergDataset.getFilePaths(); + Assert.assertEquals(actual, expected); + } + + /** + * Test case to copy all the file paths for a mocked iceberg table. This is a full copy overwriting everything on the destination Review Comment: that's right... updated my comment conveying the same. I understand it could lead to confusion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
