[GitHub] [gobblin] homatthew commented on a diff in pull request #3561: [GOBBLIN-1704] Purge offline helix instances during startup

[GitBox]

homatthew commented on code in PR #3561:
URL: https://github.com/apache/gobblin/pull/3561#discussion_r972324729


##########
gobblin-yarn/src/test/java/org/apache/gobblin/yarn/YarnServiceTest.java:
##########
@@ -303,19 +303,18 @@ public void testExceedResourceLimit() {
   static class TestYarnService extends YarnService {
     public TestYarnService(Config config, String applicationName, String 
applicationId, YarnConfiguration yarnConfiguration,
         FileSystem fs, EventBus eventBus) throws Exception {
-      super(config, applicationName, applicationId, yarnConfiguration, fs, 
eventBus, getMockHelixManager(config));
+      super(config, applicationName, applicationId, yarnConfiguration, fs, 
eventBus, getMockHelixManager(config), getMockHelixAdmin());
     }
 
     private static HelixManager getMockHelixManager(Config config) {
       HelixManager helixManager = Mockito.mock(HelixManager.class);
-      HelixAdmin helixAdmin = Mockito.mock(HelixAdmin.class);
       HelixDataAccessor helixDataAccessor = 
Mockito.mock(HelixDataAccessor.class);
       PropertyKey propertyKey = Mockito.mock(PropertyKey.class);
       PropertyKey.Builder propertyKeyBuilder = 
Mockito.mock(PropertyKey.Builder.class);
 
       
Mockito.when(helixManager.getInstanceName()).thenReturn("helixInstance1");
       
Mockito.when(helixManager.getClusterName()).thenReturn(config.getString(GobblinClusterConfigurationKeys.HELIX_CLUSTER_NAME_KEY));
-      Mockito.doNothing().when(helixAdmin).enableInstance(Mockito.anyString(), 
Mockito.anyString(), Mockito.anyBoolean());
+//

Review Comment:
   TODO: remove this random // 



##########
gobblin-yarn/src/test/java/org/apache/gobblin/yarn/YarnServiceTest.java:
##########
@@ -303,19 +303,18 @@ public void testExceedResourceLimit() {
   static class TestYarnService extends YarnService {
     public TestYarnService(Config config, String applicationName, String 
applicationId, YarnConfiguration yarnConfiguration,
         FileSystem fs, EventBus eventBus) throws Exception {
-      super(config, applicationName, applicationId, yarnConfiguration, fs, 
eventBus, getMockHelixManager(config));
+      super(config, applicationName, applicationId, yarnConfiguration, fs, 
eventBus, getMockHelixManager(config), getMockHelixAdmin());
     }
 
     private static HelixManager getMockHelixManager(Config config) {
       HelixManager helixManager = Mockito.mock(HelixManager.class);
-      HelixAdmin helixAdmin = Mockito.mock(HelixAdmin.class);
       HelixDataAccessor helixDataAccessor = 
Mockito.mock(HelixDataAccessor.class);
       PropertyKey propertyKey = Mockito.mock(PropertyKey.class);
       PropertyKey.Builder propertyKeyBuilder = 
Mockito.mock(PropertyKey.Builder.class);
 
       
Mockito.when(helixManager.getInstanceName()).thenReturn("helixInstance1");
       
Mockito.when(helixManager.getClusterName()).thenReturn(config.getString(GobblinClusterConfigurationKeys.HELIX_CLUSTER_NAME_KEY));
-      Mockito.doNothing().when(helixAdmin).enableInstance(Mockito.anyString(), 
Mockito.anyString(), Mockito.anyBoolean());
+//

Review Comment:
   TODO: remove this random // on next iteration



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org