[jira] [Work logged] (GOBBLIN-1704) Purge offline helix instances during startup

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/GOBBLIN-1704?focusedWorklogId=809252&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-809252
 ]

ASF GitHub Bot logged work on GOBBLIN-1704:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Sep/22 18:53
            Start Date: 15/Sep/22 18:53
    Worklog Time Spent: 10m 
      Work Description: homatthew commented on code in PR #3561:
URL: https://github.com/apache/gobblin/pull/3561#discussion_r972324729


##########
gobblin-yarn/src/test/java/org/apache/gobblin/yarn/YarnServiceTest.java:
##########
@@ -303,19 +303,18 @@ public void testExceedResourceLimit() {
   static class TestYarnService extends YarnService {
     public TestYarnService(Config config, String applicationName, String 
applicationId, YarnConfiguration yarnConfiguration,
         FileSystem fs, EventBus eventBus) throws Exception {
-      super(config, applicationName, applicationId, yarnConfiguration, fs, 
eventBus, getMockHelixManager(config));
+      super(config, applicationName, applicationId, yarnConfiguration, fs, 
eventBus, getMockHelixManager(config), getMockHelixAdmin());
     }
 
     private static HelixManager getMockHelixManager(Config config) {
       HelixManager helixManager = Mockito.mock(HelixManager.class);
-      HelixAdmin helixAdmin = Mockito.mock(HelixAdmin.class);
       HelixDataAccessor helixDataAccessor = 
Mockito.mock(HelixDataAccessor.class);
       PropertyKey propertyKey = Mockito.mock(PropertyKey.class);
       PropertyKey.Builder propertyKeyBuilder = 
Mockito.mock(PropertyKey.Builder.class);
 
       
Mockito.when(helixManager.getInstanceName()).thenReturn("helixInstance1");
       
Mockito.when(helixManager.getClusterName()).thenReturn(config.getString(GobblinClusterConfigurationKeys.HELIX_CLUSTER_NAME_KEY));
-      Mockito.doNothing().when(helixAdmin).enableInstance(Mockito.anyString(), 
Mockito.anyString(), Mockito.anyBoolean());
+//

Review Comment:
   TODO: remove this random // 



##########
gobblin-yarn/src/test/java/org/apache/gobblin/yarn/YarnServiceTest.java:
##########
@@ -303,19 +303,18 @@ public void testExceedResourceLimit() {
   static class TestYarnService extends YarnService {
     public TestYarnService(Config config, String applicationName, String 
applicationId, YarnConfiguration yarnConfiguration,
         FileSystem fs, EventBus eventBus) throws Exception {
-      super(config, applicationName, applicationId, yarnConfiguration, fs, 
eventBus, getMockHelixManager(config));
+      super(config, applicationName, applicationId, yarnConfiguration, fs, 
eventBus, getMockHelixManager(config), getMockHelixAdmin());
     }
 
     private static HelixManager getMockHelixManager(Config config) {
       HelixManager helixManager = Mockito.mock(HelixManager.class);
-      HelixAdmin helixAdmin = Mockito.mock(HelixAdmin.class);
       HelixDataAccessor helixDataAccessor = 
Mockito.mock(HelixDataAccessor.class);
       PropertyKey propertyKey = Mockito.mock(PropertyKey.class);
       PropertyKey.Builder propertyKeyBuilder = 
Mockito.mock(PropertyKey.Builder.class);
 
       
Mockito.when(helixManager.getInstanceName()).thenReturn("helixInstance1");
       
Mockito.when(helixManager.getClusterName()).thenReturn(config.getString(GobblinClusterConfigurationKeys.HELIX_CLUSTER_NAME_KEY));
-      Mockito.doNothing().when(helixAdmin).enableInstance(Mockito.anyString(), 
Mockito.anyString(), Mockito.anyBoolean());
+//

Review Comment:
   TODO: remove this random // on next iteration





Issue Time Tracking
-------------------

    Worklog Id:     (was: 809252)
    Time Spent: 1h 20m  (was: 1h 10m)

> Purge offline helix instances during startup
> --------------------------------------------
>
>                 Key: GOBBLIN-1704
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1704
>             Project: Apache Gobblin
>          Issue Type: New Feature
>            Reporter: Matthew Ho
>            Priority: Major
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)