Will-Lo commented on code in PR #3560:
URL: https://github.com/apache/gobblin/pull/3560#discussion_r975677535
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergDataset.java:
##########
@@ -202,14 +202,11 @@ DatasetDescriptor getDestinationDataset() {
private DatasetDescriptor getDatasetDescriptor(Optional<String>
stringMetastoreURI) {
String destinationTable = this.getDbName() + "." +
this.getInputTableName();
- URI hiveMetastoreURI = null;
- if (stringMetastoreURI.isPresent()) {
- hiveMetastoreURI = URI.create(stringMetastoreURI.get());
- }
+ URI hiveMetastoreURI = stringMetastoreURI.isPresent() ?
URI.create(stringMetastoreURI.get()) : null;
DatasetDescriptor destinationDataset =
new DatasetDescriptor(DatasetConstants.PLATFORM_ICEBERG,
hiveMetastoreURI, destinationTable);
- destinationDataset.addMetadata(DatasetConstants.FS_URI,
this.getFs().getUri().toString());
+ destinationDataset.addMetadata(DatasetConstants.FS_URI,
this.getSourceFs().getUri().toString());
Review Comment:
Why is the destinationDataset using the source FS? It can be on a different
filesystem uri here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
