umustafi commented on code in PR #3570:
URL: https://github.com/apache/gobblin/pull/3570#discussion_r982961629
##########
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/kafka/client/GobblinKafkaConsumerClient.java:
##########
@@ -169,6 +169,8 @@ default long committed(KafkaPartition partition) {
public default void assignAndSeek(List<KafkaPartition> topicPartitions,
Map<KafkaPartition, LongWatermark> topicWatermarksMap) { return; }
+ public default void initializeClient(String topic) { return; }
Review Comment:
This method is what will contain the partition assignment and offset setting
logic to initialize the consumer. Since `SpecChangeMonitor` and
`HighLevelConsumer` expect the consumer to be a class with the interface of
`GobblinKafkaConsumerClient` there needs to be a method in this interface that
can be called to setup the client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
