rdsr opened a new pull request, #3574:
URL: https://github.com/apache/gobblin/pull/3574

   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN-1715) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-XXX
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if 
applicable):
   As mentioned in the ticket the existing array resizing is buggy for ORC's 
vectorized row batch.  In almost all the cases we should fall back on the 
'enlargeFactor' option. In some cases where throughput may be a big concern. We 
should enable the proposed approach below.  We've seen some benefits of using 
the current approach. 
   
   1. Major GC pauses have reduced
   BEFORE 
![Before](https://user-images.githubusercontent.com/129474/193365599-87151649-9edc-4849-9d20-227613715aba.png)
   AFTER 
![After](https://user-images.githubusercontent.com/129474/193365616-82bad31f-b3b8-421e-94a2-043bf37a7082.png)
   
   3. Memory is only allocated when needed which when compared to the old 
approach allocated a lot more memory even when it was not required. [For 
details please see the ticket]
   BEFORE:  
![before2](https://user-images.githubusercontent.com/129474/193365800-bad1b199-bc93-4029-9cc0-e82ab02211af.png)
   AFTER:  ![Screen Shot 2022-09-30 at 3 41 05 
PM](https://user-images.githubusercontent.com/129474/193365939-f7bd7cca-213b-4603-a869-ef3f1093a5d4.png)
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   ### Commits
   - [x ] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       4. Subject is limited to 50 characters
       5. Subject does not end with a period
       6. Subject uses the imperative mood ("add", not "adding")
       7. Body wraps at 72 characters
       8. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to