[
https://issues.apache.org/jira/browse/GOBBLIN-1724?focusedWorklogId=816887&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-816887
]
ASF GitHub Bot logged work on GOBBLIN-1724:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Oct/22 07:25
Start Date: 14/Oct/22 07:25
Worklog Time Spent: 10m
Work Description: Will-Lo opened a new pull request, #3583:
URL: https://github.com/apache/gobblin/pull/3583
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1724
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
Support a flowgraph format where nodes can be shared between subgraphs. This
allows for less repetition and cleaner hierarchies within the flowgraph.
It will follow the following structure
```
/flowgraph
../nodeA
..../nodeB
......edgeAB.properties
../nodeB
....nodeB.properties
/nodes
..nodeA.properties
..nodeB.properties
```
Where nodeA will use the shared properties, and nodeB will use the union of
the properties in nodeB from /flowgraph and the shared properties.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 816887)
Remaining Estimate: 0h
Time Spent: 10m
> Support a flowgraph layout for shared node configurations
> ---------------------------------------------------------
>
> Key: GOBBLIN-1724
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1724
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: William Lo
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the GaaS Flowgraph assumes that there will be one separate
> flowgraph for each configured use case, but this adds for a large amount of
> duplication when supporting multiple flowgraphs.
> We should support a layout where there can be a directory for shared nodes
> between each flowgraph, and each flowgraph can overwrite properties for these
> nodes if needed.
> e.g.
> {code:java}
> /flowgraph
> ../nodeA
> ..../nodeB
> ......edgeAB.properties
> ../nodeB
> ....nodeB.properties
> /nodes
> ..nodeA.properties
> ..nodeB.properties{code}
> Where nodeA will use the shared properties, and nodeB will use the union of
> the properties in /flowgraph and the shared properties.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
