[
https://issues.apache.org/jira/browse/GOBBLIN-1721?focusedWorklogId=817851&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-817851
]
ASF GitHub Bot logged work on GOBBLIN-1721:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Oct/22 00:16
Start Date: 18/Oct/22 00:16
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on code in PR #3580:
URL: https://github.com/apache/gobblin/pull/3580#discussion_r997607325
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixDistributeJobExecutionLauncher.java:
##########
@@ -110,6 +110,8 @@ class GobblinHelixDistributeJobExecutionLauncher implements
JobExecutionLauncher
@Getter
private DistributeJobMonitor jobMonitor;
+ private final Config configs;
Review Comment:
Can we rename it to be combinedConfigs?
Issue Time Tracking
-------------------
Worklog Id: (was: 817851)
Time Spent: 0.5h (was: 20m)
> Give option to cancel helix workflow through Delete API to avoid job hanging
> ----------------------------------------------------------------------------
>
> Key: GOBBLIN-1721
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1721
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-cluster
> Reporter: Hanghang Liu
> Assignee: Hung Tran
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently when we receive a job restart(handleUpdateJobConfigArrival),
> GobblinHelixJobLauncher will firstly call helixTaskDriver.waitToStop to stop
> the workflow, then initiate the new one. We observe the behavior of Helix
> taking exceptionally long to stop the workflow, making the job state staying
> in STOPPING status. This will make waitToStop timeout and throw exception all
> the time, making the new flow never be able to launch.
> We can utilize Delete API in this case since our job is stateless for Helix,
> to avoid job hanging.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
