[
https://issues.apache.org/jira/browse/GOBBLIN-1728?focusedWorklogId=818554&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-818554
]
ASF GitHub Bot logged work on GOBBLIN-1728:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Oct/22 17:48
Start Date: 19/Oct/22 17:48
Worklog Time Spent: 10m
Work Description: homatthew commented on code in PR #3586:
URL: https://github.com/apache/gobblin/pull/3586#discussion_r999770296
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnService.java:
##########
@@ -789,11 +815,17 @@ private ImmutableMap.Builder<String, String>
buildContainerStatusEventMetadata(C
/**
* Get the number of matching container requests for the specified resource
memory and cores.
+ * Due to YARN-1902, this API is not 100% accurate. However, {@link
AMRMClientCallbackHandler#onContainersAllocated(List)}
+ * contains logic for best effort clean up of duplicate requests, and in
practice is pretty accurate.
Review Comment:
This comment is in reference to line `898`. The accuracy of this API request
is actually very subtle due to
[`Yarn-1902`](https://issues.apache.org/jira/browse/YARN-1902). The workaround
is best effort but in my testing was surprisingly accurate.
While testing, I deleted the if statement code block near `898` and the
number of container requests exploded. See the details in the ticket if anyone
is curious
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnService.java:
##########
@@ -789,11 +815,17 @@ private ImmutableMap.Builder<String, String>
buildContainerStatusEventMetadata(C
/**
* Get the number of matching container requests for the specified resource
memory and cores.
+ * Due to YARN-1902, this API is not 100% accurate. However, {@link
AMRMClientCallbackHandler#onContainersAllocated(List)}
+ * contains logic for best effort clean up of duplicate requests, and in
practice is pretty accurate.
Review Comment:
This comment is in reference to line `898`. The accuracy of this API request
is actually very subtle due to
[`Yarn-1902`](https://issues.apache.org/jira/browse/YARN-1902). The workaround
is best effort but in my testing was surprisingly accurate.
While testing, I deleted the if statement code block near `898` and the
number of container requests exploded. See the details in the ticket if anyone
if curious
Issue Time Tracking
-------------------
Worklog Id: (was: 818554)
Time Spent: 1h 50m (was: 1h 40m)
> Yarn Service requests too many containers due to improper calculation
> ---------------------------------------------------------------------
>
> Key: GOBBLIN-1728
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1728
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Yarn Service is responsible for calculating the number of instances based on
> the helix tasks. Yarn service tracks the number of instances by asking Yarn
> for the number of resource requests and the number of allocated containers.
>
> It uses this count to determine if it should ask for more containers or
> shrink the number of containers. This calculation is currently done
> improperly and we continue to request containers when we have enough
> requested.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
