ZihanLi58 commented on code in PR #3587:
URL: https://github.com/apache/gobblin/pull/3587#discussion_r999797516
##########
gobblin-utility/src/main/java/org/apache/gobblin/util/AvroUtils.java:
##########
@@ -95,7 +95,7 @@ public class AvroUtils {
public static final String AVRO_SUFFIX = ".avro";
- private static final String SCHEMA_CREATION_TIME_KEY = "CreatedOn";
+ public static final String SCHEMA_CREATION_TIME_KEY = "CreatedOn";
Review Comment:
Why do we do this change, I think AvroUtils handles all the operation
related to this prop?
##########
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/writer/HiveMetadataWriter.java:
##########
@@ -80,12 +80,18 @@ public class HiveMetadataWriter implements MetadataWriter {
private static final String HIVE_REGISTRATION_WHITELIST =
"hive.registration.whitelist";
private static final String HIVE_REGISTRATION_BLACKLIST =
"hive.registration.blacklist";
+ private static final String HIVE_USE_LATEST_SCHEMA_WHITELIST =
"hive.use.latest.schema.whitelist";
Review Comment:
Suggest to change it to allowlist & denylist
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
