homatthew commented on code in PR #3586:
URL: https://github.com/apache/gobblin/pull/3586#discussion_r1001052159
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnService.java:
##########
@@ -845,8 +877,6 @@ public void onContainersAllocated(List<Container>
containers) {
instanceName = null;
}
}
- allocatedContainerCountMap.put(containerHelixTag,
Review Comment:
I re-read the API and I think you're correct.
https://hadoop.apache.org/docs/stable/hadoop-yarn/hadoop-yarn-client/apidocs/org/apache/hadoop/yarn/client/api/async/AMRMClientAsync.CallbackHandler.html
Because this method is triggered by heartbeat and this method is called
after completion, maybe any implementation would work here since it's not even
concurrent lol. All writes to this map actually seem single threaded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
