[ 
https://issues.apache.org/jira/browse/GOBBLIN-1728?focusedWorklogId=818965&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-818965
 ]

ASF GitHub Bot logged work on GOBBLIN-1728:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Oct/22 23:51
            Start Date: 20/Oct/22 23:51
    Worklog Time Spent: 10m 
      Work Description: homatthew commented on code in PR #3586:
URL: https://github.com/apache/gobblin/pull/3586#discussion_r1001225111


##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnAutoScalingManager.java:
##########
@@ -266,7 +266,7 @@ void runInternal() {
       }
       slidingWindowReservoir.add(yarnContainerRequestBundle);
 
-      log.debug("There are {} containers being requested in total, tag-count 
map {}, tag-resource map {}",
+      log.info("There are {} containers being requested in total, tag-count 
map {}, tag-resource map {}",

Review Comment:
   I'll remove this change and set back to debug. I don't see much value in the 
tag-resource map actually





Issue Time Tracking
-------------------

    Worklog Id:     (was: 818965)
    Time Spent: 4h 20m  (was: 4h 10m)

> Yarn Service requests too many containers due to improper calculation
> ---------------------------------------------------------------------
>
>                 Key: GOBBLIN-1728
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1728
>             Project: Apache Gobblin
>          Issue Type: New Feature
>            Reporter: Matthew Ho
>            Priority: Major
>          Time Spent: 4h 20m
>  Remaining Estimate: 0h
>
> Yarn Service is responsible for calculating the number of instances based on 
> the helix tasks. Yarn service tracks the number of instances by asking Yarn 
> for the number of resource requests and the number of allocated containers.
>  
> It uses this count to determine if it should ask for more containers or 
> shrink the number of containers. This calculation is currently done 
> improperly and we continue to request containers when we have enough 
> requested.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to