umustafi commented on code in PR #3593:
URL: https://github.com/apache/gobblin/pull/3593#discussion_r1014478848
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java:
##########
@@ -50,9 +51,10 @@ public class DagActionStoreChangeMonitor extends
HighLevelConsumer {
public static final String DAG_ACTION_CHANGE_MONITOR_PREFIX =
"dagActionChangeStore";
// Metrics
- ContextAwareMeter killsInvoked;
- ContextAwareMeter resumesInvoked;
- ContextAwareMeter unexpectedErrors;
+ private ContextAwareMeter killsInvoked;
+ private ContextAwareMeter resumesInvoked;
+ private ContextAwareMeter unexpectedErrors;
+ private Meter messageProcessedMeter;
Review Comment:
why do you use normal `Meter` instead of `ContextAwareMeter`? Also we should
end all the names in "Meter" or none of them ie: `messagesProcessed` or
`killsInvokedMeter`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
