[
https://issues.apache.org/jira/browse/GOBBLIN-1737?focusedWorklogId=823584&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-823584
]
ASF GitHub Bot logged work on GOBBLIN-1737:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Nov/22 23:27
Start Date: 04/Nov/22 23:27
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3595:
URL: https://github.com/apache/gobblin/pull/3595#discussion_r1014521337
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java:
##########
@@ -390,7 +390,8 @@ public synchronized void setActive(boolean active) {
this.dagManagerMetrics.activate();
- UserQuotaManager quotaManager = new InMemoryUserQuotaManager(config);
+ UserQuotaManager quotaManager =
GobblinConstructorUtils.invokeConstructor(UserQuotaManager.class,
+ ConfigUtils.getString(config,
ServiceConfigKeys.QUOTA_MANAGER_CLASS,
ServiceConfigKeys.DEFAULT_QUOTA_MANAGER), config);
Review Comment:
do you see other types of quota manager besides in memory actually being
used?
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/MysqlUserQuotaManager.java:
##########
@@ -295,7 +302,8 @@ public MysqlQuotaStore(BasicDataSource dataSource, String
tableName)
DECREASE_FLOWGROUP_COUNT_SQL = "UPDATE " + tableName + " SET
flowgroup_count=flowgroup_count-1 WHERE name = ?";
DELETE_USER_SQL = "DELETE FROM " + tableName + " WHERE name = ? AND
user_count<1 AND flowgroup_count<1";
- String createQuotaTable = "CREATE TABLE IF NOT EXISTS " + tableName + "
(name VARCHAR(20) CHARACTER SET latin1 NOT NULL, "
+ //Increase the length of name as we include the executor uri in it
+ String createQuotaTable = "CREATE TABLE IF NOT EXISTS " + tableName + "
(name VARCHAR(500) CHARACTER SET latin1 NOT NULL, "
Review Comment:
anything else contained in table name? how long is executor uri max? It will
be helpful to give idea of what table name will be
Issue Time Tracking
-------------------
Worklog Id: (was: 823584)
Time Spent: 0.5h (was: 20m)
> Fix bug when using mysql user quota manager
> -------------------------------------------
>
> Key: GOBBLIN-1737
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1737
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> # Change the way we get config to to consistent with other mysql store
> # Only check quota in compiler when the flow compile successful and explain
> flag is not set
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
