ZihanLi58 commented on code in PR #3595:
URL: https://github.com/apache/gobblin/pull/3595#discussion_r1014530751


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/MysqlUserQuotaManager.java:
##########
@@ -295,7 +302,8 @@ public MysqlQuotaStore(BasicDataSource dataSource, String 
tableName)
       DECREASE_FLOWGROUP_COUNT_SQL = "UPDATE " + tableName + " SET 
flowgroup_count=flowgroup_count-1 WHERE name = ?";
       DELETE_USER_SQL = "DELETE FROM " + tableName + " WHERE name = ? AND 
user_count<1 AND flowgroup_count<1";
 
-      String createQuotaTable = "CREATE TABLE IF NOT EXISTS " + tableName + " 
(name VARCHAR(20) CHARACTER SET latin1 NOT NULL, "
+      //Increase the length of name as we include the executor uri in it
+      String createQuotaTable = "CREATE TABLE IF NOT EXISTS " + tableName + " 
(name VARCHAR(500) CHARACTER SET latin1 NOT NULL, "

Review Comment:
   Under name, it will be "user name for the quota" + "spec uri". I tried 200 
and see it does not work so directly give 500



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to