[GitHub] [gobblin] umustafi commented on a diff in pull request #3612: [GOBBLIN-1752] Fix race condition where FSTemplateCatalog would update at the same t…

[GitBox]

umustafi commented on code in PR #3612:
URL: https://github.com/apache/gobblin/pull/3612#discussion_r1043756358


##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/FsFlowGraphMonitor.java:
##########
@@ -61,24 +63,29 @@ public class FsFlowGraphMonitor extends AbstractIdleService 
implements FlowGraph
   private final PathAlterationObserverScheduler pathAlterationDetector;
   private final FSPathAlterationFlowGraphListener listener;
   private final PathAlterationObserver observer;
-  private final Path flowGraphPath;
+  private Path flowGraphPath;
+  private Path observedPath;
   private final MultiHopFlowCompiler compiler;
   private final CountDownLatch initComplete;
   private static final Config DEFAULT_FALLBACK = 
ConfigFactory.parseMap(ImmutableMap.<String, Object>builder()
       .put(ConfigurationKeys.FLOWGRAPH_ABSOLUTE_DIR, 
DEFAULT_FS_FLOWGRAPH_MONITOR_ABSOLUTE_DIR)
       .put(ConfigurationKeys.FLOWGRAPH_BASE_DIR, 
DEFAULT_FS_FLOWGRAPH_MONITOR_FLOWGRAPH_DIR)
       .put(ConfigurationKeys.FLOWGRAPH_POLLING_INTERVAL, 
DEFAULT_FLOWGRAPH_POLLING_INTERVAL)
       .put(ConfigurationKeys.FLOWGRAPH_JAVA_PROPS_EXTENSIONS, 
ConfigurationKeys.DEFAULT_PROPERTIES_EXTENSIONS)
+      .put(MONITOR_TEMPLATE_CATALOG_CHANGES, false)

Review Comment:
   why is this false by default? I thought we want this enabled to refresh from 
both together



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org