[
https://issues.apache.org/jira/browse/GOBBLIN-1764?focusedWorklogId=839150&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839150
]
ASF GitHub Bot logged work on GOBBLIN-1764:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jan/23 20:51
Start Date: 13/Jan/23 20:51
Worklog Time Spent: 10m
Work Description: homatthew commented on code in PR #3623:
URL: https://github.com/apache/gobblin/pull/3623#discussion_r1070031403
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java:
##########
@@ -219,7 +229,8 @@ protected void
processMessage(DecodeableKafkaRecord<byte[],byte[]> message) {
* @throws IOException
*/
@VisibleForTesting
- static void addJobStatusToStateStore(org.apache.gobblin.configuration.State
jobStatus, StateStore stateStore)
+ static void addJobStatusToStateStore(org.apache.gobblin.configuration.State
jobStatus, StateStore stateStore,
+ Optional<GaaSObservabilityEventProducer> eventProducer)
Review Comment:
Curious on our philosophy for using optional as a parameter. Why not use
nulls + overloading. Java optionals are best used as a return value but as an
input, I think it makes the developer experience less readable (There are
plenty of debates on it on the internet).
Although, I have seen the pattern used in some other parts of Gobblin, so
clearly past developers felt it was okay.
Issue Time Tracking
-------------------
Worklog Id: (was: 839150)
Time Spent: 50m (was: 40m)
> Emit GaaSObservabilityEvent
> ---------------------------
>
> Key: GOBBLIN-1764
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1764
> Project: Apache Gobblin
> Issue Type: New Feature
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> GaaSObservabilityEvents are a new events that provides a job summary from
> pipelines in GaaS. It differs from GobblinTrackingEvents as it runs once per
> job pipeline, and it intended to be easily queryable and alert on.
> We want to emit this observability event from GaaS by deriving it from a
> job's job status. Since this feature is Experimental and WIP, it is not
> expected to fill out all of the fields immediately.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
