[
https://issues.apache.org/jira/browse/GOBBLIN-1770?focusedWorklogId=841886&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-841886
]
ASF GitHub Bot logged work on GOBBLIN-1770:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jan/23 00:30
Start Date: 27/Jan/23 00:30
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3630:
URL: https://github.com/apache/gobblin/pull/3630#issuecomment-1405856942
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3630?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3630](https://codecov.io/gh/apache/gobblin/pull/3630?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(ffc186b) into
[master](https://codecov.io/gh/apache/gobblin/commit/3dd0657e9ac87ce34fdaa196145d441eeba5e340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(3dd0657) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3630 +/- ##
============================================
- Coverage 49.01% 48.99% -0.02%
- Complexity 9185 9186 +1
============================================
Files 1751 1751
Lines 67864 67893 +29
Branches 7734 7739 +5
============================================
+ Hits 33261 33264 +3
- Misses 31502 31523 +21
- Partials 3101 3106 +5
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...ice/monitoring/GaaSObservabilityEventProducer.java](https://codecov.io/gh/apache/gobblin/pull/3630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9HYWFTT2JzZXJ2YWJpbGl0eUV2ZW50UHJvZHVjZXIuamF2YQ==)
| `11.86% <ø> (ø)` | |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/gobblin/pull/3630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `85.71% <0.00%> (-7.15%)` | :arrow_down: |
|
[...bblin/data/management/copy/OwnerAndPermission.java](https://codecov.io/gh/apache/gobblin/pull/3630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvT3duZXJBbmRQZXJtaXNzaW9uLmphdmE=)
| `20.00% <0.00%> (-5.00%)` | :arrow_down: |
|
[...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/gobblin/pull/3630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh)
| `60.21% <0.00%> (-4.31%)` | :arrow_down: |
|
[...lin/data/management/copy/ManifestBasedDataset.java](https://codecov.io/gh/apache/gobblin/pull/3630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvTWFuaWZlc3RCYXNlZERhdGFzZXQuamF2YQ==)
| `51.78% <0.00%> (-3.99%)` | :arrow_down: |
|
[...a/management/copy/publisher/CopyDataPublisher.java](https://codecov.io/gh/apache/gobblin/pull/3630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvcHVibGlzaGVyL0NvcHlEYXRhUHVibGlzaGVyLmphdmE=)
| `73.54% <0.00%> (-1.95%)` | :arrow_down: |
|
[...nt/copy/writer/FileAwareInputStreamDataWriter.java](https://codecov.io/gh/apache/gobblin/pull/3630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvd3JpdGVyL0ZpbGVBd2FyZUlucHV0U3RyZWFtRGF0YVdyaXRlci5qYXZh)
| `73.17% <0.00%> (-0.47%)` | :arrow_down: |
|
[...pache/gobblin/runtime/kafka/HighLevelConsumer.java](https://codecov.io/gh/apache/gobblin/pull/3630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUva2Fma2EvSGlnaExldmVsQ29uc3VtZXIuamF2YQ==)
| `0.00% <0.00%> (ø)` | |
|
[...lin/service/monitoring/SpecStoreChangeMonitor.java](https://codecov.io/gh/apache/gobblin/pull/3630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9TcGVjU3RvcmVDaGFuZ2VNb25pdG9yLmphdmE=)
| `0.00% <0.00%> (ø)` | |
|
[...obblin/data/management/copy/CopyConfiguration.java](https://codecov.io/gh/apache/gobblin/pull/3630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvQ29weUNvbmZpZ3VyYXRpb24uamF2YQ==)
| `86.95% <0.00%> (ø)` | |
| ... and [5
more](https://codecov.io/gh/apache/gobblin/pull/3630?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Issue Time Tracking
-------------------
Worklog Id: (was: 841886)
Time Spent: 20m (was: 10m)
> Fix Serialization of GaaSObservabilityEvent by allowing null values for Issue
> details and and properties
> --------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1770
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1770
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: William Lo
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When looking into the IssueRepository before the creation of
> GaaSObservabilityEvents, many issues do not populate their fields for details
> and summary. This is because the Issue details are composed of a stack trace,
> but since Issues can be composed of warn/error logs and stack traces, it is
> not guaranteed that every issue has a corresponding stack trace.
> However, from investigation it looks like the automated troubleshooter will
> always populate the issue severity, code, and summary.
> We should guard against this when generating a GaaSObservabilityEvent.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
