vikrambohra commented on code in PR #3632:
URL: https://github.com/apache/gobblin/pull/3632#discussion_r1097936139
##########
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreUtils.java:
##########
@@ -256,6 +256,23 @@ public static SerDeInfo getSerDeInfo(HiveRegistrationUnit
unit) {
return si;
}
+ /**
+ * Util for detecting if a table has a complex union (aka non-optional
unions) column types. Iceberg currently does
+ * not natively support uniontype because types differently as structs.
Until this feature is added in iceberg, this
+ * function can be used to detect these types of tables for gobblin specific
workarounds
+ *
+ * See https://github.com/apache/iceberg/issues/189
+ *
+ * @param t
+ * @return if hive table contains complex uniontype columns
+ */
+ public static boolean containsUnionTypeColumn(HiveTable t) {
Review Comment:
Can we have another method that takes Hive native table object instead of
Gobblin Hive Table wrapper object and one calling the other?
##########
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreUtils.java:
##########
@@ -256,6 +256,23 @@ public static SerDeInfo getSerDeInfo(HiveRegistrationUnit
unit) {
return si;
}
+ /**
+ * Util for detecting if a table has a complex union (aka non-optional
unions) column types. Iceberg currently does
Review Comment:
This is a simple utility method to tell if a hive table contains a complex
union. Lets not complicate my mentioning iceberg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
