meethngala commented on code in PR #3616:
URL: https://github.com/apache/gobblin/pull/3616#discussion_r1099626433
##########
gobblin-data-management/src/test/java/org/apache/gobblin/data/management/copy/writer/FileAwareInputStreamDataWriterTest.java:
##########
@@ -402,10 +409,169 @@ public void testCommit() throws IOException {
// previously existing paths should not have permissions changed
fileStatus = this.fs.getFileStatus(existingOutputPath);
Assert.assertEquals(fileStatus.getPermission(), existingPathPermission);
-
Assert.assertFalse(this.fs.exists(writer.stagingDir));
}
+ @Test
+ public void testCommitWithAclPreservationWhenAncestorPathsAbsent() throws
IOException {
+ String fileName = "file";
+ // Asemble destination paths
+ String destinationExistingToken = "destination";
+ String destinationAdditionalTokens = "path";
+ Path destination = new Path(new Path(new Path("/",
destinationExistingToken), destinationAdditionalTokens), fileName);
+ Path destinationWithoutLeadingSeparator = new Path(new
Path(destinationExistingToken, destinationAdditionalTokens), fileName);
Review Comment:
ahh... that's a good catch. I essentially borrowed these paths from old test
cases... I have made the changes and pushed a latest commit for the same!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
