ZihanLi58 commented on code in PR #3641:
URL: https://github.com/apache/gobblin/pull/3641#discussion_r1103262698
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java:
##########
@@ -1048,9 +1049,6 @@ private void submitJob(DagNode<JobExecutionPlan> dagNode)
{
/**
* Method that defines the actions to be performed when a job finishes
either successfully or with failure.
* This method updates the state of the dag and performs clean up actions
as necessary.
- * TODO : Dag should have a status field, like JobExecutionPlan has. This
method should update that field,
Review Comment:
Seems we remove failedDagIdsFinishRunning, failedDagIdsFinishAllPossible in
this PR as well. But I don't have enough context for what these two are used
for right now and how current implementation can support the same use case.
Should we separate this into a separate PR? Or at lease, please describe the
change in PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
