jack-moseley commented on code in PR #3633:
URL: https://github.com/apache/gobblin/pull/3633#discussion_r1105139677
##########
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/writer/HiveMetadataWriter.java:
##########
@@ -281,15 +281,24 @@ private boolean inHiveSpecCache(String tableKey) {
}
private void updateLatestSchemaMapWithExistingSchema(String dbName, String
tableName, String tableKey) throws IOException {
+ updateLatestSchemaMapWithExistingSchema(dbName, tableName, tableKey,
useExistingTableSchemaAllowDenyList, hiveRegister, latestSchemaMap);
+ }
+
+ // returns if latest schema map was updated with the existing schema in Hive
Review Comment:
Meant to say "returns true if"?
##########
gobblin-iceberg/src/test/java/org/apache/gobblin/iceberg/writer/HiveMetadataWriterTest.java:
##########
@@ -350,6 +403,34 @@ private String writeRecord(File file) throws IOException {
return path;
}
+ /**
+ * Test class for exposing methods for exposing internal HiveMetaWriter
functions without making them public.
Review Comment:
Typo
"Test class ~~for exposing methods~~ for exposing internal HiveMetaWriter
functions"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
