homatthew commented on code in PR #3645:
URL: https://github.com/apache/gobblin/pull/3645#discussion_r1107568271


##########
gobblin-metastore/src/main/java/org/apache/gobblin/runtime/StateStoreBasedWatermarkStorage.java:
##########
@@ -55,10 +56,10 @@ public class StateStoreBasedWatermarkStorage implements 
WatermarkStorage {
    * A watermark prefix that is compatible with different watermark storage 
implementations.
    * As such, this prefix should not include any characters disallowed in a 
{@link java.net.URI}.
    */
-  private static final String WATERMARK_STORAGE_PREFIX="streamingWatermarks_";
+  protected static final String 
WATERMARK_STORAGE_PREFIX="streamingWatermarks_";
 
   public final StateStore<CheckpointableWatermarkState> _stateStore;
-  private final String _storeName;

Review Comment:
   Extensions of this class should have access to this for interacting with the 
state store



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to