meethngala commented on code in PR #3643:
URL: https://github.com/apache/gobblin/pull/3643#discussion_r1113609977
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergDataset.java:
##########
@@ -87,8 +87,8 @@ public IcebergDataset(String db, String table, IcebergTable
icebergTbl, Properti
this.icebergTable = icebergTbl;
this.properties = properties;
this.sourceFs = sourceFs;
- this.sourceCatalogMetastoreURI = getAsOptionalURI(this.properties,
IcebergDatasetFinder.ICEBERG_HIVE_CATALOG_METASTORE_URI_KEY);
- this.targetCatalogMetastoreURI = getAsOptionalURI(this.properties,
TARGET_METASTORE_URI_KEY);
+ this.sourceCatalogURI = getAsOptionalURI(this.properties,
IcebergDatasetFinder.ICEBERG_SRC_CATALOG_URI_KEY);
Review Comment:
I have encapsulated the catalog uri information to be a part of
`IcebergCatalog` and added the TODO for target catalog!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
