ZihanLi58 commented on code in PR #3661:
URL: https://github.com/apache/gobblin/pull/3661#discussion_r1136218532
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java:
##########
@@ -687,7 +687,6 @@ private void cancelDagNode(DagNode<JobExecutionPlan>
dagNodeToCancel) throws Exe
Future future = dagNodeToCancel.getValue().getJobFuture().get();
String serializedFuture =
DagManagerUtils.getSpecProducer(dagNodeToCancel).serializeAddSpecResponse(future);
props.put(ConfigurationKeys.SPEC_PRODUCER_SERIALIZED_FUTURE,
serializedFuture);
- sendCancellationEvent(dagNodeToCancel.getValue());
Review Comment:
Have concerns on this line. After removing this, are we able to handle
normal cancel requests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
