Will-Lo commented on code in PR #3663:
URL: https://github.com/apache/gobblin/pull/3663#discussion_r1154893472
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergDatasetFinder.java:
##########
@@ -125,14 +126,14 @@ protected IcebergCatalog createIcebergCatalog(Properties
properties, CatalogLoca
switch (location) {
case SOURCE:
catalogUri = properties.getProperty(ICEBERG_SRC_CATALOG_URI_KEY);
- Preconditions.checkNotNull(catalogUri, "Source Catalog Table Service
URI is required");
+ Preconditions.checkNotNull(catalogUri, "Provided: {%s} Source Catalog
Table Service URI is required", catalogUri);
Review Comment:
Correct me if I'm wrong here, but wouldn't this message always equate to:
```
Provided: null Source Catalog Table Service URI is required
```
I think I just wanted you to provide the ICEBERG_SRC_CATALOG_URI_KEY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
