[
https://issues.apache.org/jira/browse/GOBBLIN-1806?focusedWorklogId=854906&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-854906
]
ASF GitHub Bot logged work on GOBBLIN-1806:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/23 23:43
Start Date: 04/Apr/23 23:43
Worklog Time Spent: 10m
Work Description: Will-Lo opened a new pull request, #3667:
URL: https://github.com/apache/gobblin/pull/3667
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1806
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
This PR adds a `JobSummaryTimer` which is emitted right before the
`JobCommitTimer`, after the datasets are written and published to the
destination.
Collection of the records/bytes is dependent on the DataWriter implementing
`bytesWritten()` and `recordsWritten()`, which is implemented by most writers
and those that extend from the `InstrumentedDataWriter`.
Gobblin-as-a-Service ingests these JobSummaryTimer events and serializes
them into the GaaSObservabilityEvent
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Added unit tests to test that every job with writers emits a JobSummaryTimer
and the serializer/deserialization in the GaaSObservabilityEvent
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 854906)
Remaining Estimate: 0h
Time Spent: 10m
> Create a GTE for recording bytes/records written for each dataset in a
> Gobblin job
> ----------------------------------------------------------------------------------
>
> Key: GOBBLIN-1806
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1806
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Gobblin collects a lot of writer metrics on number of bytes and records
> written to the sinks, but does not emit these metrics as part of a
> GobblinTrackingEvent.
> We want to emit these in a GobblinTrackingEvent so that it can be ingested by
> montioring systems and GaaS.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
