jack-moseley commented on code in PR #3670:
URL: https://github.com/apache/gobblin/pull/3670#discussion_r1163308997
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/retention/DatasetCleaner.java:
##########
@@ -176,7 +176,7 @@ public void onSuccess(Void arg0) {
@Override
public void close() throws IOException {
try {
- if (this.finishCleanSignal.isPresent()) {
+ if (this.finishCleanSignal != null &&
this.finishCleanSignal.isPresent()) {
Review Comment:
Yes I found that if an exception is thrown during setup (e.g. issue
instantiating the datasetsFinder), this will still be null which will cause the
job to fail without actually logging the exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
