homatthew commented on code in PR #3673:
URL: https://github.com/apache/gobblin/pull/3673#discussion_r1163310390
##########
gradle/scripts/dependencyDefinitions.gradle:
##########
@@ -123,7 +123,7 @@ ext.externalDependency = [
"guiceMultibindings":
"com.google.inject.extensions:guice-multibindings:4.0",
"guiceServlet": "com.google.inject.extensions:guice-servlet:4.0",
"derby": "org.apache.derby:derby:10.12.1.1",
- "mockito": "org.mockito:mockito-inline:4.11.0", // upgraded to allow
mocking for constructors, static and final methods; specifically for iceberg
distcp
+ "mockito": "org.mockito:mockito-core:4.11.0",
Review Comment:
Add a comment here as a warning not to change this to mockito-inline. If you
need features from mockito-inline, please add mockito-inline as a mockmaker
plugin
Example: https://github.com/apache/gobblin/pull/3651/files#r1163182255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
